Bug 25308

Summary: REGRESSION (r42182): Build fails after following build instructions on webkit.org fail when using VC++ Express
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: sfalken
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch + changelog v1 eric: review+

Adam Roben (:aroben)
Reported 2009-04-21 08:22:10 PDT
r42182 changed build-webkit to invoke pdevenv instead of invoking Visual Studio or VC++ Express directly. But this has caused the build to fail when following the build instructions on webkit.org and using VC++ Express. The build fails because windows.h cannot be found. Presumably this is because pdevenv passes the /useenv switch to VC++ Express, and this causes VC++ Express to ignore the Platform SDK paths that were added to it as part of the build instructions.
Attachments
patch + changelog v1 (3.12 KB, patch)
2009-05-05 08:28 PDT, Adam Roben (:aroben) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2009-05-05 08:28:09 PDT
Created attachment 30020 [details] patch + changelog v1
Eric Seidel (no email)
Comment 2 2009-05-05 08:29:18 PDT
Comment on attachment 30020 [details] patch + changelog v1 I'm not really an expert here, but this looks sane enough to me.
Adam Roben (:aroben)
Comment 3 2009-05-05 08:58:56 PDT
Landed as r43239
Note You need to log in before you can comment on or make changes to this bug.