Bug 253066
| Summary: | [webkitcorepy] AutoInstall unable to install pytest-asyncio (or other packages without setup.py) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cgarcia, clopez, dpino, fujii.hironori, jbedard, lmoura, pangle, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Sam Sneddon [:gsnedders]
258166@main (bug 249564) updated the AutoInstalled versions of pytest and its plugins, including pytest-asyncio. pytest-asyncio, as of 0.19, no longer includes a setup.py: it relies on the build frontend reading pyproject.toml, per PEP 517 (https://peps.python.org/pep-0517/).
However, the AutoInstall has no knowledge of PEP 517, and instead tries to run a setup.py, and falls back to just copying the whole source packages over and hoping for the best. This (unsurprisingly) doesn't work well.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jonathan Bedard
Looks like pytest-asyncio includes a setup.cfg, so it's note entirely in a world with only pyproject.toml yet. We also would need to bump our setuptools version to support pyproject.toml, which I'm not against in the long term, but I think needs a tad more validation.
Fixing pytest-asyncio, however, doesn't require bumping setuptools. It just requires laying down a dummy setup.py file which picks up setup.cfg through setuptools. We don't even have to touch our invocation of setup.py, which is actually somewhat surprising.
Radar WebKit Bug Importer
<rdar://problem/106095209>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/10880
EWS
Committed 261097@main (752a2873e756): <https://commits.webkit.org/261097@main>
Reviewed commits have been landed. Closing PR #10880 and removing active labels.
EWS
Committed 259548.354@safari-7615-branch (c2279007a3a5): <https://commits.webkit.org/259548.354@safari-7615-branch>
Reviewed commits have been landed. Closing PR #431 and removing active labels.
Fujii Hironori
Regressed: Bug 253421 – REGRESSION(261097@main) [Win] test-webkitpy: Failed to install pytest-asyncio-0.20.3!