Bug 25300

Summary: microsoft virtual earth overlay error
Product: WebKit Reporter: Corey Mitchell <cmitch13>
Component: WebCore JavaScriptAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, jayayche, zwarich
Priority: P2 Keywords: HasReduction, InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://maps.live.com
See Also: https://bugs.webkit.org/show_bug.cgi?id=186439
Attachments:
Description Flags
Reduction none

Corey Mitchell
Reported 2009-04-20 14:44:30 PDT
Create an overlay on the map (collections > add pushpin). Move the pushpin. Error: javascript://pushin%20hover (in address bar) Safari can’t run the script “//pushin hover” because Safari doesn’t allow JavaScript to be used in this way. (on page)
Attachments
Reduction (97 bytes, text/html)
2009-04-20 23:43 PDT, Cameron Zwarich (cpst) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-04-20 15:07:10 PDT
<rdar://problem/6809619>
Cameron Zwarich (cpst)
Comment 2 2009-04-20 23:43:30 PDT
Created attachment 29642 [details] Reduction Here's a simple reduction: <a href="javascript://pushin hover">Click here</a> It works fine (and gets ignored) with a %20 instead of a space.
Cameron Zwarich (cpst)
Comment 3 2009-04-20 23:54:02 PDT
This is an invalid URL, so this check fails, even though the text of the URL begins with "javascript": if (!url.protocolIs("javascript")) return false; It seems that when Safari gets a loader callback about this being an invalid URL, it displays the message in the bug report. I'm not really sure what to do here. Should Safari not display a separate error page, or should we special-case this at the WebKit level?
Cameron Zwarich (cpst)
Comment 4 2009-04-21 00:30:40 PDT
I forgot to mention: that check I am referring to is in FrameLoader::executeIfJavaScriptURL().
Corey Mitchell
Comment 5 2009-04-23 09:02:58 PDT
is there an update on this? are you guys proceeding with a fix?
Cameron Zwarich (cpst)
Comment 6 2009-04-23 12:55:29 PDT
The fix is to accept some malformed JavaScript URLs. I'm not immediately sure of the right way to go about it, though.
Alexey Proskuryakov
Comment 7 2009-05-20 23:13:00 PDT
This was fixed in <http://trac.webkit.org/changeset/43929>+<http://trac.webkit.org/changeset/43949>.
Mark Rowe (bdash)
Comment 8 2009-05-24 15:45:51 PDT
*** Bug 25995 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.