Summary: | Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint on RenderSVGModelObject | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aglenning, deanm, simon.fraser, zimmermann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 20769 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2009-04-17 09:55:15 PDT
Created attachment 29579 [details] Reviewed by Simon Fraser. Remove more dead code from RenderSVGHiddenContainer. lineHeight and baselinePosition used to be on RenderSVGContainer (of which this is a subclass) because RenderSVGContainer used to be a RenderBox and always the renderer for <svg> Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML) and RenderSVGViewportContainer (when inside SVG content) so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods. * rendering/RenderSVGHiddenContainer.cpp: * rendering/RenderSVGHiddenContainer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42555 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- 1 files changed, 16 insertions(+), 0 deletions(-) Created attachment 29580 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
15 files changed, 111 insertions(+), 57 deletions(-)
Comment on attachment 29579 [details]
Reviewed by Simon Fraser.
Git is confused.
I think this also has caused a small improvement to bug 14015. However, bug 14015 will be fixed (very easily) once all this refactoring is done. :) Created attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
15 files changed, 121 insertions(+), 57 deletions(-)
Comment on attachment 29581 [details]
Move RenderPath and RenderSVGContainer onto a unified clippedOverflowRectForRepaint
r=me with renaming of m_maximumPaintedRect to something more informative
*** Bug 21968 has been marked as a duplicate of this bug. *** *** Bug 20769 has been marked as a duplicate of this bug. *** Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/mac/svg/custom/focus-ring-expected.checksum M LayoutTests/platform/mac/svg/custom/focus-ring-expected.png M LayoutTests/platform/mac/svg/custom/marker-overflow-clip-expected.txt M LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.checksum M LayoutTests/platform/mac/svg/custom/scroll-hit-test-expected.png M WebCore/ChangeLog M WebCore/rendering/RenderPath.cpp M WebCore/rendering/RenderPath.h M WebCore/rendering/RenderSVGContainer.cpp M WebCore/rendering/RenderSVGContainer.h M WebCore/rendering/RenderSVGModelObject.cpp M WebCore/rendering/RenderSVGModelObject.h M WebCore/rendering/RenderSVGRoot.cpp M WebCore/rendering/RenderSVGRoot.h Committed r42613 YAY! |