Bug 25261

Summary: Implement DOMWindow.event as a custom binding in V8
Product: WebKit Reporter: Eric Roman <eroman>
Component: WebCore Misc.Assignee: Eric Roman <eroman>
Status: RESOLVED FIXED    
Severity: Normal CC: ager, dglazkov, mbelshe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Move handling of DOMWindow.event to custom getter dglazkov: review+

Description Eric Roman 2009-04-16 21:37:24 PDT 
With change <http://trac.webkit.org/changeset/42430>, the "event" attribute got moved into DOMWindow.idl. Before it was coded in JSDOMWindowBase (and in the case of v8 bindings, V8AbstractEventListener).

This bug is about updating the V8 bindings to work with the new idl.
This change should also fix two flaws in the current V8 bindings on "event":
- The "event" attribute should not be exposed to workers (just DOMWindow)
- It should be possible to shadow "window.event"

Patch coming soon.
Comment 1 Eric Roman 2009-04-17 13:08:22 PDT 
Created attachment 29587 [details]
Move handling of DOMWindow.event to custom getter
Comment 2 Dimitri Glazkov (Google) 2009-04-20 08:20:15 PDT 
Comment on attachment 29587 [details]
Move handling of DOMWindow.event to custom getter

Thanks for doing this!
Comment 3 Dimitri Glazkov (Google) 2009-04-20 08:27:51 PDT 
Landed as http://trac.webkit.org/changeset/42671.