Summary: | Finish V8 custom bindings for InspectorController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Dimitri Glazkov (Google)
2009-04-16 20:58:08 PDT
Created attachment 29571 [details]
Finish V8 custom bindings for InspectorController.
WebCore/ChangeLog | 10 +
.../v8/custom/V8InspectorControllerCustom.cpp | 267 +++++++++++++++++++-
2 files changed, 269 insertions(+), 8 deletions(-)
Comment on attachment 29571 [details] Finish V8 custom bindings for InspectorController. > +++ b/WebCore/bindings/v8/custom/V8InspectorControllerCustom.cpp > + Node* node = V8Proxy::DOMWrapperToNode<Node>(args[0]); > + if (!node) > + return v8::Undefined(); > + > + InspectorController* inspectorController = V8Proxy::ToNativeObject<InspectorController>(V8ClassIndex::INSPECTORCONTROLLER, args.Holder()); > + inspectorController->highlight(node); > + > + return v8::Undefined(); > +} ^^^ indentation is off by one there. otherwise, LGTM Doh! Fixed and landed as http://trac.webkit.org/changeset/42603. |