Summary: | AX: VoiceOver cmd-cntl-space does not follow the google.com->more link | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
chris fleizach
2009-04-16 18:30:33 PDT
Created attachment 29569 [details]
patch to fix accessibility problem with invisible elements
Comment on attachment 29569 [details] patch to fix accessibility problem with invisible elements > + bool visibilityChanged = (m_style->visibility() != newStyle->visibility() || > + m_style->zIndex() != newStyle->zIndex() || > + m_style->hasAutoZIndex() != newStyle->hasAutoZIndex()); The formatting here retains strange indenting and parentheses from the if statement. I would use this format: bool visibilityChanged = m_style->visibility() != newStyle->visibility() || m_style->zIndex() != newStyle->zIndex() || m_style->hasAutoZIndex() != newStyle->hasAutoZIndex(); Partly this is because I prefer the "operators at beginning of line" style because I think it makes it clearer that subsequent lines are continuations of the expression. And partly because I think the entire expression is easier to read if we don't do excessive indentation. r=me |