Bug 252236
| Summary: | [WPE] Build broken with external holepunch enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Miguel Gomez <magomez> |
| Component: | WPE WebKit | Assignee: | Miguel Gomez <magomez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Miguel Gomez
There are 2 build errors:
- MediaPlayerPrivate::setSize(), which is overridden by MediaPlayerPrivateHolePunch::setSize() was renamed to MediaPlayerPrivate::setPresentationSize(), so the one in MediaPlayerPrivateHolePunch must be renamed too.
- The String class constructor that receives a char* is now private, so we need to use a different way to create the mime type Strings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Miguel Gomez
Pull request: https://github.com/WebKit/WebKit/pull/10082
EWS
Committed 260251@main (38f8a723a95d): <https://commits.webkit.org/260251@main>
Reviewed commits have been landed. Closing PR #10082 and removing active labels.