Bug 25218

Summary:

Remove an "inline" keyword from method definition

Product:

WebKit

Reporter:

Eric Roman <eroman>

Component:

WebCore Misc.

Assignee:

Eric Roman <eroman>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Remove an inline keyword.	ap: review+

Description Eric Roman 2009-04-15 13:20:42 PDT

I want to remove the "inline" keyword from DOMWindow::inlineEventListenerForType.

My c++ foo isn't that strong, but I think using inline in the definition only works if the method isn't referenced externally. (And in this case, chromium references this method causing a compile failure on linux).

Removal of "inline" is consistent with a similar recent change:

http://trac.webkit.org/changeset/42450

Patch coming soon.

Comment 1 Eric Roman 2009-04-15 13:23:38 PDT

Created attachment 29514 [details]
Remove an inline keyword.

Comment 2 Alexey Proskuryakov 2009-04-16 13:00:46 PDT

Comment on attachment 29514 [details]
Remove an inline keyword.

r=me

Comment 3 Darin Fisher (:fishd, Google) 2009-04-16 15:13:15 PDT

Landed as:  http://trac.webkit.org/changeset/42593