Bug 251977
| Summary: | [GTK4] Enable threaded rendering again using 1 painting thread by default | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro |
| Priority: | P2 | Keywords: | Gtk |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=247628 https://bugs.webkit.org/show_bug.cgi?id=253108 https://bugs.webkit.org/show_bug.cgi?id=253953 https://bugs.webkit.org/show_bug.cgi?id=255923 |
||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Carlos Garcia Campos
It seems the issues with threaded rendering were actually caused by using multiple painting threads, but we can still use a single thread to move the painting off the main thread.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/9854
EWS
Committed 260059@main (4af5eb3490da): <https://commits.webkit.org/260059@main>
Reviewed commits have been landed. Closing PR #9854 and removing active labels.
Michael Catanzaro
Maybe should also change:
WTFLogAlways("The number of Nicosia painting threads is not between 1 and 8. Using the default value 4\n");
numThreads = 4;
Michael Catanzaro
Why can't WPE use one thread?
Carlos Garcia Campos
WPE doesn't enable threaded rendering by default.
Carlos Garcia Campos
The default is 4, for GTK we use 1 which is not the default value.
Michael Catanzaro
Just kind of weird for the "default" to be 4 when GTK uses 1 and WPE uses 0 and nothing uses 4. Whatever.
Michael Catanzaro
I think this was not safe to do after all. See bug #247628 and bug #253108.