| Summary: | BuilderConverter::convertLineHeight() should not return an std::optional<Length> | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | CSS | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | koivisto, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pull request: https://github.com/WebKit/WebKit/pull/9809 Committed 260027@main (c436cfbb0eb0): <https://commits.webkit.org/260027@main> Reviewed commits have been landed. Closing PR #9809 and removing active labels. |
There is this comment at the end of BuilderConverter::convertLineHeight(): // FIXME: The parser should only emit the above types, so this should never be reached. We should change the // type of this function to return just a Length (and not an Optional). return std::nullopt; Let's fix this!