Bug 25183

Summary:

Split up WebCore.vcproj's settings into vsprops files

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Adam Roben (:aroben) <aroben>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sfalken

Priority:

Keywords:

PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
patch + changelog v1	darin: review+

Adam Roben (:aroben)

Reported 2009-04-14 08:59:28 PDT

WebCore.vcproj has become quite bloated, with its large numbers of configurations and settings. Splitting the settings out into separate .vsprops files should make WebCore.vcproj more maintainable, and reduce bloat (since the settings won't have to be duplicated for each confiuration).

Attachments
patch + changelog v1 (40.81 KB, patch) 2009-04-14 09:02 PDT, Adam Roben (:aroben)	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2009-04-14 09:02:15 PDT

Created attachment 29469 [details] patch + changelog v1

Darin Adler

Comment 2 2009-04-14 10:21:05 PDT

Comment on attachment 29469 [details] patch + changelog v1 r=me

Steve Falkenburg

Comment 3 2009-04-14 10:38:37 PDT

It would be nice to eliminate the Release_PGO configurations, since I don't think anyone is actively using those.

Adam Roben (:aroben)

Comment 4 2009-04-14 11:06:21 PDT

(In reply to comment #3) > It would be nice to eliminate the Release_PGO configurations, since I don't > think anyone is actively using those. That would be an easy follow-up step. I almost broke out the PGO-specific config options into a WebCorePGO.vsprops, but I suspected that we would be deleting that configuration entirely soon so I didn't bother.

Adam Roben (:aroben)

Comment 5 2009-04-14 11:10:20 PDT

Landed as r42503

Note You need to log in before you can comment on or make changes to this bug.