Bug 251667
| Summary: | Implement a more accurate currentStackPointer(). | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> |
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | berto, bugs-noreply, fujii.hironori, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=252196 | ||
Mark Lam
currentStackPointer() was already accurate for some ports (the ones that support inline assembly), but for others and when using a Debug build, we fall back to a C runtime function that only gives an approximate value. This patch implements a currentStackPointer() that is accurate for all currently support ports even when using a Debug build.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104993866>
Mark Lam
Pull request: https://github.com/WebKit/WebKit/pull/9585
EWS
Committed 259818@main (7dbed20e73b0): <https://commits.webkit.org/259818@main>
Reviewed commits have been landed. Closing PR #9585 and removing active labels.
Fujii Hironori
Bug 251770 – [Win] REGRESSION(259818@main) error LNK2019: unresolved external symbol currentStackPointer
Michael Catanzaro
OK, this will break Fedora due to missing required architectures ppc64le and s390x, and will likely be worse for Debian since they have tons of architectures. I'll look closer next week, but ideally we would fall back to generic/inaccurate implementation rather than failing to build.
Michael Catanzaro
I found a simple typo causing the build failure. Fix incoming in bug #252196.