Bug 251623

Summary: [media-controls] LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() should reliably disable those features
Product: WebKit Reporter: Antoine Quint <graouts>
Component: MediaAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, megan_gardner, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Antoine Quint 2023-02-02 11:30:23 PST 
The way the media controls code deals with LayoutTraits.supportsAirPlay() and LayoutTraits.supportPiP() to disable the relevant features is not ideal since it completely bypasses the MediaSupport classes for them or fails to hide their buttons. The best way to deal with this is to ensure the relevant controls are disabled if the feature is off, ensuring they will not appear anywhere in the UI.
Comment 1 Antoine Quint 2023-02-02 11:34:09 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9547
Comment 2 EWS 2023-02-02 11:41:11 PST 
Committed 259767@main (6aff2cbcaecd): <https://commits.webkit.org/259767@main>

Reviewed commits have been landed. Closing PR #9547 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-02 11:42:19 PST 
<rdar://problem/104970740>