Bug 251450
| Summary: | Prefix the SVGAnimationElement range setting methods with "set" instead of "calculate" | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> |
| Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | sabouhallawa, webkit-bug-importer, zimmermann |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Said Abou-Hallawa
We need to change the names of these methods:
1) calculateFromAndToValues()
2) calculateFromAndByValues()
3) calculateToAtEndOfDurationValue()
And this will match the names of the SVGAttributeAnimator methods which are called by these methods.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104881126>
Said Abou-Hallawa
Pull request: https://github.com/WebKit/WebKit/pull/9401
EWS
Committed 259705@main (dd0930cde59d): <https://commits.webkit.org/259705@main>
Reviewed commits have been landed. Closing PR #9401 and removing active labels.