Bug 251330
| Summary: | [Wasm-GC] Support arrays of vectors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Chevalier <tjc> |
| Component: | WebAssembly | Assignee: | Asumu Takikawa <asumu> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | justin_michaud, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247394 | ||
Tim Chevalier
https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md implies that arrays of vectors should be supported, e.g. the description of `array.new_canon_data`: "t' is numeric, vector, or packed". That implies that `array.get` and `array.set` should work on arrays of vectors. However, this functionality is currently not implemented in the `JSWebAssemblyArray` class (see the implementations of `get()` and `set()`.) The AIR implementations of `array.new_canon` and `array.get` also use `emitCoerceFromI64` on the input or result value, which crashes with an assertion failure when the source type is `v128`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105050265>
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/22727
EWS
Committed 273663@main (4750403b1e46): <https://commits.webkit.org/273663@main>
Reviewed commits have been landed. Closing PR #22727 and removing active labels.