Bug 251246

Summary:	Event dispatching on disabled form controls
Product:	WebKit	Reporter:	Karl Dubost <karlcow>
Component:	DOM	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, cyb.ai.815, ntim, saschanaz, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
URL:	https://wpt.fyi/results/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
See Also:	https://bugs.webkit.org/show_bug.cgi?id=55942 https://bugs.webkit.org/show_bug.cgi?id=258078 https://bugs.webkit.org/show_bug.cgi?id=259132
Bug Depends on:
Bug Blocks:	34465, 89041, 124852, 237097, 102841, 219188

Description Karl Dubost 2023-01-26 20:47:04 PST

Part of the Interop 2023.
There is a proposal to improve the interop of events dispatched on on disabled form controls
https://wpt.fyi/results/html/semantics/disabled-elements/disabled-event-dispatch.tentative.html?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat

Comment 1 Radar WebKit Bug Importer 2023-01-26 20:47:16 PST Comment hidden (obsolete)

<rdar://problem/104727618>

Comment 2 Radar WebKit Bug Importer 2023-01-26 20:47:35 PST

<rdar://problem/104727624>

Comment 3 Karl Dubost 2023-01-26 21:00:18 PST

SeeAlso https://github.com/WebKit/standards-positions/issues/78

That is a risky change for Web Compatibility. This needs to be handled carefully.
That might create breakages by changing expectations and require a Quirk.

Comment 4 Tim Nguyen (:ntim) 2023-03-10 13:15:34 PST

Removing these 2 lines: https://searchfox.org/wubkat/source/Source/WebCore/dom/EventContext.cpp#92-94 seems to fix some of the failures

Comment 5 Tim Nguyen (:ntim) 2023-03-10 13:15:57 PST

(In reply to Tim Nguyen (:ntim) from comment #4)
> Removing these 2 lines:
> https://searchfox.org/wubkat/source/Source/WebCore/dom/EventContext.cpp#92-
> 94 seems to fix some of the failures

Permalink: https://searchfox.org/wubkat/rev/2b326434751bf80c7f34c5d5e02dc0ad619d4826/Source/WebCore/dom/EventContext.cpp#92-94

Comment 6 Tim Nguyen (:ntim) 2023-03-30 16:26:08 PDT

There's also: https://searchfox.org/wubkat/rev/4c1d077ec985eb840a20e5ffb65eb2b73fb89d31/Source/WebCore/dom/Element.cpp#460

Comment 7 Chris Dumez 2023-05-12 17:21:04 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13837

Comment 8 EWS 2023-05-15 20:33:38 PDT

Committed 264098@main (9ed97a1ca58c): <https://commits.webkit.org/264098@main>

Reviewed commits have been landed. Closing PR #13837 and removing active labels.