Bug 251183
| Summary: | Restrict the set of defaults-overridable flags to better match shipping Safari | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
The new feature generator logic attempts to persist all `internal` feature flags such that a developer can use a 'WebKitDebug'-prefix for a setting to override it. This is only desired for a small set of feature flags (those that lived in the Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml file previously).
This patch does the following:
1. Corrects a handful of feature flags that were moved from `internal` to `embedder`, improperly.
2. Adds a new key, `defaultsOverridable` to UnifiedWebPreferences.yaml. Flags that have this key with a `true` value will get additional logic to support 'WebKitDebug'-prefix overrides.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://104657361>
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/9163
EWS
Committed 259458@main (0f58ae8a9cfe): <https://commits.webkit.org/259458@main>
Reviewed commits have been landed. Closing PR #9163 and removing active labels.