Bug 251176

Summary: Fix negative shadow repaint issue
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 256537    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Ahmad Saleem 2023-01-25 15:08:25 PST 
Hi Team,

While going through Blink's commit, which seems to a good fix since intermittently we have same painting issue, at least what I have experienced with this testcase:

Test Case - https://jsfiddle.net/dLxq1pm7/

^ Safari 16.2, STP162 some time does not show full "red" and have gap in it till some time passes or you resize.

Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=164709

I just wanted to raise so we can fix this.

Thanks!
Comment 1 Simon Fraser (smfr) 2023-01-25 15:23:36 PST 
Seems reasonable to merge.
Comment 2 Ahmad Saleem 2023-01-25 15:25:25 PST 
(In reply to Simon Fraser (smfr) from comment #1)
> Seems reasonable to merge.

Yep, was doing PR in the background but right now in Draft - https://github.com/WebKit/WebKit/pull/9157
Comment 3 EWS 2023-01-27 09:45:56 PST 
Committed 259497@main (b10e15662611): <https://commits.webkit.org/259497@main>

Reviewed commits have been landed. Closing PR #9157 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-01-27 09:46:20 PST 
<rdar://problem/104749948>
Comment 5 WebKit Commit Bot 2023-05-08 11:47:02 PDT 
Re-opened since this is blocked by bug 256480
Comment 6 Ahmad Saleem 2023-05-08 15:53:49 PDT 
Just for future, RenderObject.cpp change was moved to "RenderBox.cpp" in Blink and later this was overwritten by this:

https://src.chromium.org/viewvc/blink?view=revision&revision=177971
Comment 7 zalan 2023-05-09 17:57:16 PDT 
Created attachment 466301 [details]
Patch
Comment 8 zalan 2023-05-09 19:41:57 PDT 
Created attachment 466302 [details]
Patch
Comment 9 EWS 2023-05-10 08:00:01 PDT 
Committed 263899@main (b8d4023a9816): <https://commits.webkit.org/263899@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 466302 [details].