Bug 251075
| Summary: | [GLib] WebKitWebHitTestResult should use composition instead of subclassing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | WebKit API | Assignee: | Adrian Perez <aperez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=251008 https://bugs.webkit.org/show_bug.cgi?id=243663 |
||
| Bug Depends on: | |||
| Bug Blocks: | 210100 | ||
Adrian Perez
While working on issue #251008 we noticed that the WebKitHitTestResult type
cannot be made final because it has a subclass, WebKitWebHitTestResult, in
the injected bundle. More info at
https://github.com/WebKit/WebKit/pull/8972#issuecomment-1401161473
Ideally, we would prefer that WebKitHitTestResult is actually a final type,
which needs the WebKitWebHitTestResult subclass to use composition instead.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
Pull request: https://github.com/WebKit/WebKit/pull/9036
EWS
Committed 259651@main (71df87cb0f48): <https://commits.webkit.org/259651@main>
Reviewed commits have been landed. Closing PR #9036 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/104892179>