Bug 25106

Summary:

Mismatched virtual function signatures in animations

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

URL:

http://demo.webapp-net.com

Attachments:

Description	Flags
Patch	mitz: review+

Description Simon Fraser (smfr) 2009-04-08 18:18:19 PDT

AnimationBase has 
virtual void endAnimation(bool, double)
and the double is never used.

Everything else has
virtual void endAnimation(bool)

I think this is causing a real bug on http://demo.webapp-net.com, where there's an opacity animation that's never cleaned up.

Comment 1 Simon Fraser (smfr) 2009-04-08 18:29:08 PDT

Created attachment 29353 [details]
Patch

Comment 2 Simon Fraser (smfr) 2009-04-08 18:34:15 PDT

http://trac.webkit.org/changeset/42346