Bug 25091

Summary: There is no mechanism to register threads.
Product: WebKit Reporter: Ben Murdoch <benm>
Component: PlatformAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Implements thread registration.
none
Alternative patch after IRC discussion
ap: review+
New patch with levin's changes none

Ben Murdoch
Reported 2009-04-08 02:32:38 PDT
On the Android platform, threads must be registered with the VM before they can run. There is no way in WebKit to perform this registration. I have a patch that implements this functionality on Android and provides empty implementations for other platforms.
Attachments
Implements thread registration. (12.95 KB, patch)
2009-04-08 02:37 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
Alternative patch after IRC discussion (2.89 KB, patch)
2009-04-09 06:37 PDT, Ben Murdoch 		ap: review+
DetailsFormatted DiffDiff
New patch with levin's changes (2.85 KB, patch)
2009-04-09 11:37 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2009-04-08 02:37:11 PDT
Created attachment 29328 [details] Implements thread registration.
Ben Murdoch
Comment 2 2009-04-09 06:37:48 PDT
Created attachment 29366 [details] Alternative patch after IRC discussion
Alexey Proskuryakov
Comment 3 2009-04-09 06:39:28 PDT
Comment on attachment 29366 [details] Alternative patch after IRC discussion Looks fine, r=me.
David Levin
Comment 4 2009-04-09 11:12:37 PDT
Assigned to me for landing. Asked benm for two changes: 1. s/NULL/0/ 2. Switch to c++ style casts. (which I wanted him to do to verify that the changes built fine for him).
Ben Murdoch
Comment 5 2009-04-09 11:37:55 PDT
Created attachment 29369 [details] New patch with levin's changes
David Levin
Comment 6 2009-04-09 13:47:08 PDT
Committed <http://trac.webkit.org/changeset/42366>
Note You need to log in before you can comment on or make changes to this bug.