Bug 250909
| Summary: | Rename hasTransform() to isTransformed() on RenderObject and RenderLayer | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Layout and Rendering | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=250901 | ||
Antoine Quint
The name "hasTransform" is kind of convoluted in WebCore due to historically denoting on RenderStyle whether a "transform" property was set to some non-none value. With the addition of more CSS properties affecting transform, and the addition of RenderStyle::affectsTransform(), we should also rename "hasTransform" on RenderLayer and RenderObject to be "isTransformed" to better match what this method denotes.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/8886
EWS
Committed 259171@main (c934d4911662): <https://commits.webkit.org/259171@main>
Reviewed commits have been landed. Closing PR #8886 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/104512541>