Bug 250879
| Summary: | Delete unused Windows UA string logic | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, bfulgham, fujii.hironori, stephan.szabo, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=280295 | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came cross another clean-up commit, which can be merged into WebKit.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6d5bdc2b3dc4b675747a86b190fa555c5a018014
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/win/SystemInfo.cpp#80 etc.
Just wanted to raise, so we can track and clean-up some old code and enjoy cleaner WebKit.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
We do use this function, so probably no easy cleanup:
Source/WebKitLegacy/win/WebView.cpp: static const NeverDestroyed<String> prefix = makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/", webKitVersionString(), " (KHTML, like Gecko)");
Source/WebCore/platform/win/UserAgentWin.cpp: return makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/605.1.15 (KHTML, like Gecko)",
Radar WebKit Bug Importer
<rdar://problem/104721654>
Fujii Hironori
Yes, it's used. Closed.