Bug 250870
| Summary: | Remove HTMLMediaElement.webkitHasClosedCaptions/webkitClosedCaptionsVisible | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble, karlcow, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another non-standard removal (replaced by Text Track API), so I thought to raise this bug and get input:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=159317
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.cpp#7056 & https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.idl#98
Just wanted to get input whether it is something worth exploring to clean-up and removal some more code from Webkit while also aiming for standardisation.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/104451148>
Karl Dubost
Yes I believe this can be safely removed.
It has no impact on both WPT and Browser Compatibility, but it makes it another opportunity to remove code cruft and another vector for detecting safari.
EWS
Committed 267780@main (0a73c4dbb7a0): <https://commits.webkit.org/267780@main>
Reviewed commits have been landed. Closing PR #17501 and removing active labels.