Bug 250857

Summary: Small improvement to VMInspector::dumpRegisters().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Mark Lam
Reported 2023-01-19 12:23:22 PST
When dumping the topCallFrame, we should use numCalleeLocals instead of numVars when we don't know where the next frame is. Using numVars does not give us visibility into all locals that may be in use. Also fix CodeBlock::nameForRegister() to just use VirtualRegister's dumper instead of doing custom and duplicate work.
Attachments
Radar WebKit Bug Importer
Comment 1 2023-01-19 12:23:45 PST
Mark Lam
Comment 2 2023-01-19 12:26:34 PST
EWS
Comment 3 2023-01-19 13:21:15 PST
Committed 259109@main (8ad0557c285f): <https://commits.webkit.org/259109@main> Reviewed commits have been landed. Closing PR #8848 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.