Bug 25082

Summary: Clean up repaint logic when composited layers come and go
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog mitz: review+

Simon Fraser (smfr)
Reported 2009-04-07 14:26:10 PDT
The current code that tries to repaint when RenderLayers become, and stop being compositing does not get it right. This needs cleaning up.
Attachments
Patch, changelog (11.31 KB, patch)
2009-04-07 14:32 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-04-07 14:32:55 PDT
Created attachment 29317 [details] Patch, changelog
mitz
Comment 2 2009-04-07 14:41:34 PDT
Comment on attachment 29317 [details] Patch, changelog > + if (!repaintContainer) > + repaintContainer= m_renderView; Missing space before the =. > + // Update the compositing state of the given layer. Returns true if that state changed. > + bool updateLayerCompositingState(RenderLayer*, bool mustRepaint = true); I would like to channel Darin Adler and suggest that you use an enum instead of a bool. r=me
Simon Fraser (smfr)
Comment 3 2009-04-07 15:41:20 PDT
I did the enum. http://trac.webkit.org/changeset/42291
Note You need to log in before you can comment on or make changes to this bug.