Bug 250639

Summary:

Fix handling of bidirectional override

Product:

WebKit

Reporter:

Ahmad Saleem <ahmad.saleem792>

Component:

Text

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto, mmaxfield, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Ahmad Saleem 2023-01-15 03:56:35 PST

Hi Team,

While going through Blink's commit, I came across another failing test in Safari 16.2 and Safari Technology Preview 161:

Test Case - https://jsfiddle.net/yajew02c/show

^ The text is not contained within bounds of white box, 'daal' (in roman Arabic or Urdu) is in grey region.

Chrome Canary 111 and Firefox Nightly 110 works fine in above:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/fe79ee4457111490064d8bf9b6c5dce97f26b5d4

Don't know whether 1-1 merge is possible or not but just wanted to raise so we can track it.

Thanks!

Comment 1 zalan 2023-01-20 20:07:34 PST

Created attachment 464585 [details]
Patch

Comment 2 zalan 2023-01-20 20:09:05 PST

we don't use BidiResolver in IFC anymore, so fixing it in WebKit requires a very different approach (see patch).

Comment 3 zalan 2023-01-21 06:39:23 PST

Created attachment 464586 [details]
Patch

Comment 4 EWS 2023-01-21 12:49:58 PST

Committed 259172@main (ac34f5d6508f): <https://commits.webkit.org/259172@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464586 [details].

Comment 5 Radar WebKit Bug Importer 2023-01-21 12:50:17 PST

<rdar://problem/104514372>