Summary: | [GTK] Implement layoutTestController.waitForPolicyDelegate | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jmalonzo | ||||||
Priority: | P2 | Keywords: | Gtk, LayoutTestFailure, PlatformOnly | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2009-04-03 14:12:12 PDT
Created attachment 30227 [details]
implement waitForPolicyDelegate and enable mailto tests
Comment on attachment 30227 [details]
implement waitForPolicyDelegate and enable mailto tests
Patch needs more work.. clearing review.
Created attachment 30230 [details]
updated patch
Updated the patch to check for waitForPolicy instead of waitToDumpWatchdog. This should also pass the existing enabled tests.
Comment on attachment 30230 [details]
updated patch
Looks great.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/gtk/Skipped M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp M WebKitTools/DumpRenderTree/gtk/DumpRenderTreeGtk.h M WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp Committed r43760 |