Bug 25036

Summary: [GTK] Implement layoutTestController.waitForPolicyDelegate
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jmalonzo
Priority: P2 Keywords: Gtk, LayoutTestFailure, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
implement waitForPolicyDelegate and enable mailto tests
none
updated patch zecke: review+

Adam Roben (:aroben)
Reported 2009-04-03 14:12:12 PDT
r42056 added layoutTestController.waitForPolicyDelegate, and r42057 made a number of tests depend on it. This functionality needs to be implemented in the GTK+ port in order to run these tests. I've added these tests to LayoutTests/platform/gtk/Skipped.
Attachments
implement waitForPolicyDelegate and enable mailto tests (6.39 KB, patch)
2009-05-12 07:26 PDT, Jan Alonzo 		no flags
DetailsFormatted DiffDiff
updated patch (7.52 KB, patch)
2009-05-12 08:34 PDT, Jan Alonzo 		zecke: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jan Alonzo
Comment 1 2009-05-12 07:26:37 PDT
Created attachment 30227 [details] implement waitForPolicyDelegate and enable mailto tests
Jan Alonzo
Comment 2 2009-05-12 08:04:06 PDT
Comment on attachment 30227 [details] implement waitForPolicyDelegate and enable mailto tests Patch needs more work.. clearing review.
Jan Alonzo
Comment 3 2009-05-12 08:34:36 PDT
Created attachment 30230 [details] updated patch Updated the patch to check for waitForPolicy instead of waitToDumpWatchdog. This should also pass the existing enabled tests.
Holger Freyther
Comment 4 2009-05-14 05:31:30 PDT
Comment on attachment 30230 [details] updated patch Looks great.
Eric Seidel (no email)
Comment 5 2009-05-15 00:57:23 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/gtk/Skipped M WebKitTools/ChangeLog M WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp M WebKitTools/DumpRenderTree/gtk/DumpRenderTreeGtk.h M WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp Committed r43760
Note You need to log in before you can comment on or make changes to this bug.