Bug 250270

Summary: REGRESSION (256989@main): YouTube "read more" links are missing, long comments cut off
Product: WebKit Reporter: Aaron Graves <ajgraves>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Critical CC: abotella, bfulgham, koivisto, orichidsjy, porfirioribeiro, simon.fraser, vprelovac, webkit-bug-importer, zalan
Priority: P1 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Mac (Apple Silicon)   
OS: macOS 13   
Attachments:
Description Flags
Screenshot from production Safari
none
Screenshot from Safari Tech Preview, showing the missing Read more link
none
Patch
none
Patch
none
Patch none

Aaron Graves
Reported 2023-01-07 07:29:38 PST
Created attachment 464396 [details] Screenshot from production Safari Navigate to any video on YouTube where there are long comments (and would normally trigger a read more link). I recommend https://www.youtube.com/watch?v=cUkbdqw9pBk. Note that the read more link is missing, and all you get is the cut off text.
Attachments
Screenshot from production Safari (153.95 KB, image/png)
2023-01-07 07:29 PST, Aaron Graves 		no flags
Details
Screenshot from Safari Tech Preview, showing the missing Read more link (130.81 KB, image/png)
2023-01-07 07:30 PST, Aaron Graves 		no flags
Details
Patch (10.71 KB, patch)
2023-01-09 15:47 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (19.94 KB, patch)
2023-01-09 20:35 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (19.98 KB, patch)
2023-01-10 08:17 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aaron Graves
Comment 1 2023-01-07 07:30:11 PST
Created attachment 464397 [details] Screenshot from Safari Tech Preview, showing the missing Read more link
alan
Comment 2 2023-01-07 08:08:44 PST
<rdar://103942782>
alan
Comment 3 2023-01-09 12:47:50 PST
This is caused by the lack of scrollable overflow with clamped content (IFC does not compute lines beyond the clamped content). It starts working fine soon after scrollable overflow is added.
alan
Comment 4 2023-01-09 15:47:22 PST
Created attachment 464428 [details] Patch
alan
Comment 5 2023-01-09 16:03:00 PST
*** Bug 250071 has been marked as a duplicate of this bug. ***
alan
Comment 6 2023-01-09 20:35:37 PST
Created attachment 464438 [details] Patch
alan
Comment 7 2023-01-10 08:17:33 PST
Created attachment 464442 [details] Patch
EWS
Comment 8 2023-01-10 09:53:50 PST
Committed 258730@main (f34b777b4bff): <https://commits.webkit.org/258730@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464442 [details].
Karl Dubost
Comment 9 2023-01-15 18:52:56 PST
*** Bug 250636 has been marked as a duplicate of this bug. ***
alan
Comment 10 2023-01-16 15:09:47 PST
*** Bug 250563 has been marked as a duplicate of this bug. ***
Vladimir Prelovac
Comment 11 2023-01-25 17:22:09 PST
Any idea when this will be merged/tagged? Latest SafariTP (162) still didn't include it.
alan
Comment 12 2023-01-25 18:42:56 PST
(In reply to Vladimir Prelovac from comment #11) > Any idea when this will be merged/tagged? Latest SafariTP (162) still didn't > include it. While I don't know when this is going to be merged, according to https://webkit.org/blog/13703/release-notes-for-safari-technology-preview-162/, 162 includes WebKit changes between: 258383@main…258608@main. This fix missed the cut off by ~4 days(122 commits), but it also looks to be an awfully short range compared to previous STPs (e.g. 257351@main…258382@main and 256265@main…257350@main).
Note You need to log in before you can comment on or make changes to this bug.