Bug 250235
| Summary: | Do not automatically enable 'developer' features during tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 222885 | ||
Brent Fulgham
The generator logic added in Bug 247926 also activated features with 'developer' status while running tests.
However, the 'developer' flags with a defaultValue of 'false' are generally not relevant to testing (e.g., enabling security-violating CORS state, enabling features not meant for web use cases, etc.
TestWebKitAPI tests that need these special settings already enable the individually, so we should not hard-set them to 'true' at each test iteration, as this can also enables features on platforms or configurations that need these features to be off.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103969233>
Brent Fulgham
This issue also applies to 'stable' features, which are already in the correct state for each platform, and should not be arbitrarily toggled on for testing.
Brent Fulgham
Pull request: https://github.com/WebKit/WebKit/pull/8327
Brent Fulgham
Note: After noticing issues with GTK/WPE, we decided to continue enable 'stable' feature for now.
EWS
Committed 258681@main (1a660cb880b4): <https://commits.webkit.org/258681@main>
Reviewed commits have been landed. Closing PR #8327 and removing active labels.