Bug 250227
| Summary: | Add exclusive "shouldBeGreaterThan" function to js-test.js similar to Chromium | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, rniwa, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While trying to do following PR and in the test of it:
https://github.com/WebKit/WebKit/pull/8305/files#diff-c2c39a91b22f93f030d4c452050c08bc0b5d2632af2f40215a5acc58582a0d9bR18
I noted that it has dedicated "shouldBeGreaterThan" test compared to "shouldBeGreaterThanOrEqual", we have.
I checked on Chromium source and they have it separate:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/resources/js-test.js;l=601?q=shouldBeGreaterThan
I think it would be fine and good enhancement to add it for even future use cases.
Just wanted to get opinion and raise it.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 258613@main (24d9e4a1e3d3): <https://commits.webkit.org/258613@main>
Reviewed commits have been landed. Closing PR #8321 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103987760>