Bug 250149
| Summary: | Add plumbing for Gamepad.vibrationActuator support | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebCore Misc. | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 248989 | ||
Chris Dumez
Add plumbing for Gamepad.vibrationActuator support:
- https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuator
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/8251
EWS
Committed 258559@main (7203ee047b6c): <https://commits.webkit.org/258559@main>
Reviewed commits have been landed. Closing PR #8251 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103966957>
Michael Catanzaro
Looks like this broke the GTK build:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&, WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&, WTF::CompletionHandler<void(bool)>&&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:52:22: error: no match for call to ‘(WTF::CompletionHandler<void(bool)>) (bool)’
52 | completionHandler(false);
| ~~~~~~~~~~~~~~~~~^~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp: In member function ‘virtual void WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&, WTF::CompletionHandler<void()>&&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/EmptyGamepadProvider.cpp:57:22: error: no match for call to ‘(WTF::CompletionHandler<void()>) ()’
57 | completionHandler();
| ~~~~~~~~~~~~~~~~~^~
The code *looks* correct, though...
Chris Dumez
(In reply to Michael Catanzaro from comment #4)
> Looks like this broke the GTK build:
>
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp: In member function ‘virtual void
> WebCore::EmptyGamepadProvider::playEffect(unsigned int, const WTF::String&,
> WebCore::GamepadHapticEffectType, const WebCore::GamepadEffectParameters&,
> WTF::CompletionHandler<void(bool)>&&)’:
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp:52:22: error: no match for call to
> ‘(WTF::CompletionHandler<void(bool)>) (bool)’
> 52 | completionHandler(false);
> | ~~~~~~~~~~~~~~~~~^~~~~~~
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp: In member function ‘virtual void
> WebCore::EmptyGamepadProvider::stopEffects(unsigned int, const WTF::String&,
> WTF::CompletionHandler<void()>&&)’:
> /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gamepad/
> EmptyGamepadProvider.cpp:57:22: error: no match for call to
> ‘(WTF::CompletionHandler<void()>) ()’
> 57 | completionHandler();
> | ~~~~~~~~~~~~~~~~~^~
>
> The code *looks* correct, though...
Maybe we need to include <wtf/CompletionHandler.h> inside EmptyGamepadProvider.cpp. Would you be able to try?
Michael Catanzaro
I had the same idea. Pretty sure it worked: my build is nearly done....
Michael Catanzaro
Yes, that works.
Michael Catanzaro
Re-opening for pull request https://github.com/WebKit/WebKit/pull/8331
EWS
Committed 258578@main (3383a19ab4f9): <https://commits.webkit.org/258578@main>
Reviewed commits have been landed. Closing PR #8331 and removing active labels.