Bug 25010

Summary:

Convert all JS function invocations in InspectorController to use ScriptFunctionCall

Product:

WebKit

Reporter:

Dimitri Glazkov (Google) <dglazkov>

Component:

Web Inspector (Deprecated)

Assignee:

Dimitri Glazkov (Google) <dglazkov>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Refactor to replace all JS function invocations in InspectorController with ScriptFunctionCall, v1	timothy: review+

Dimitri Glazkov (Google)

Reported 2009-04-02 14:08:10 PDT

This is fairly straightforward refactoring.

Attachments
Refactor to replace all JS function invocations in InspectorController with ScriptFunctionCall, v1 (16.56 KB, patch) 2009-04-02 14:29 PDT, Dimitri Glazkov (Google)	timothy: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Dimitri Glazkov (Google)

Comment 1 2009-04-02 14:29:38 PDT

Created attachment 29207 [details] Refactor to replace all JS function invocations in InspectorController with ScriptFunctionCall, v1 WebCore/ChangeLog | 31 ++++++ WebCore/bindings/js/ScriptFunctionCall.cpp | 24 ++++ WebCore/bindings/js/ScriptFunctionCall.h | 9 ++ WebCore/bindings/js/ScriptObjectQuarantine.cpp | 27 +++++ WebCore/bindings/js/ScriptObjectQuarantine.h | 4 + WebCore/inspector/InspectorController.cpp | 135 +++++++---------------- WebCore/inspector/InspectorController.h | 3 - 7 files changed, 136 insertions(+), 97 deletions(-)

Dimitri Glazkov (Google)

Comment 2 2009-04-02 14:49:10 PDT

Landed as http://trac.webkit.org/changeset/42187.

Note You need to log in before you can comment on or make changes to this bug.