Bug 25005

Summary: Upstream V8WorkerContextObjectEventListener for V8 bindings.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch fishd: review+

Jian Li
Reported 2009-04-02 10:49:12 PDT
Upstream V8WorkerContextObjectEventListener for V8 bindings.
Attachments
Proposed Patch (5.92 KB, patch)
2009-04-02 10:56 PDT, Jian Li 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-04-02 10:56:43 PDT
Created attachment 29200 [details] Proposed Patch
Darin Fisher (:fishd, Google)
Comment 2 2009-04-02 13:10:46 PDT
Comment on attachment 29200 [details] Proposed Patch > +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp > +#if ENABLE(WORKERS) > + > +#include "V8WorkerContextObjectEventListener.h" > + > +#include "WorkerContextExecutionProxy.h" nit: gratuitous new line between those two includes? otherwise, R+
Jian Li
Comment 3 2009-04-02 13:34:28 PDT
(In reply to comment #2) > (From update of attachment 29200 [details] [review]) > > +++ b/WebCore/bindings/v8/V8WorkerContextObjectEventListener.cpp > > +#if ENABLE(WORKERS) > > + > > +#include "V8WorkerContextObjectEventListener.h" > > + > > +#include "WorkerContextExecutionProxy.h" > > nit: gratuitous new line between those two includes? > > > otherwise, R+ > Do we need additional new line between header file for itself and all other included files? It seems that other WebKit files are doing like this.
Dmitry Titov
Comment 4 2009-04-02 14:35:23 PDT
Landed: http://trac.webkit.org/changeset/42185
Note You need to log in before you can comment on or make changes to this bug.