| Summary: | Upstream V8EventListenerList for V8 bindings. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jian Li <jianli> | ||||||
| Component: | WebCore Misc. | Assignee: | Jian Li <jianli> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 25009 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jian Li
2009-04-02 10:30:49 PDT
Created attachment 29195 [details]
Proposed Patch
Comment on attachment 29195 [details] Proposed Patch > +++ b/WebCore/bindings/v8/V8EventListenerList.h ... > + class V8EventListenerList { > + public: > + static const size_t kMaxKeyNameLength = 254; nit: This should be renamed to maxKeyNameLength. Const variables should be named just like regular variables :) Otherwise, R+ Created attachment 29205 [details]
Proposed Patch
Fixed per darin's feedback. Please use this new patch to land.
|