Bug 25004

Summary: Upstream V8EventListenerList for V8 bindings.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 25009    
Description Flags
Proposed Patch
fishd: review+
Proposed Patch none

Description Jian Li 2009-04-02 10:30:49 PDT
Upstream V8EventListenerList for V8 bindings.
Comment 1 Jian Li 2009-04-02 10:34:30 PDT
Created attachment 29195 [details]
Proposed Patch
Comment 2 Darin Fisher (:fishd, Google) 2009-04-02 13:08:04 PDT
Comment on attachment 29195 [details]
Proposed Patch

> +++ b/WebCore/bindings/v8/V8EventListenerList.h
> +    class V8EventListenerList {
> +    public:
> +        static const size_t kMaxKeyNameLength = 254;

nit: This should be renamed to maxKeyNameLength.  Const variables should
be named just like regular variables :)

Otherwise, R+
Comment 3 Jian Li 2009-04-02 13:23:33 PDT
Created attachment 29205 [details]
Proposed Patch

Fixed per darin's feedback. Please use this new patch to land.
Comment 4 Dmitry Titov 2009-04-02 14:34:51 PDT
Landed: http://trac.webkit.org/changeset/42184