Bug 25004

Summary: Upstream V8EventListenerList for V8 bindings.
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 25009    
Attachments:
Description Flags
Proposed Patch
fishd: review+
Proposed Patch none

Jian Li
Reported 2009-04-02 10:30:49 PDT
Upstream V8EventListenerList for V8 bindings.
Attachments
Proposed Patch (8.17 KB, patch)
2009-04-02 10:34 PDT, Jian Li 		fishd: review+
DetailsFormatted DiffDiff
Proposed Patch (8.16 KB, patch)
2009-04-02 13:23 PDT, Jian Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jian Li
Comment 1 2009-04-02 10:34:30 PDT
Created attachment 29195 [details] Proposed Patch
Darin Fisher (:fishd, Google)
Comment 2 2009-04-02 13:08:04 PDT
Comment on attachment 29195 [details] Proposed Patch > +++ b/WebCore/bindings/v8/V8EventListenerList.h ... > + class V8EventListenerList { > + public: > + static const size_t kMaxKeyNameLength = 254; nit: This should be renamed to maxKeyNameLength. Const variables should be named just like regular variables :) Otherwise, R+
Jian Li
Comment 3 2009-04-02 13:23:33 PDT
Created attachment 29205 [details] Proposed Patch Fixed per darin's feedback. Please use this new patch to land.
Dmitry Titov
Comment 4 2009-04-02 14:34:51 PDT
Landed: http://trac.webkit.org/changeset/42184
Note You need to log in before you can comment on or make changes to this bug.