Summary: | Don't add empty rects during addFocusRingRects in RenderInline | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Safari Technology Preview | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ahmad Saleem
2022-12-28 18:30:05 PST
Created attachment 466314 [details]
GitHub Patch
I manage to do merge and compile this but I think Line 930 is problematic since it does not fix the failing test case, which I have attached here on local build.
Just wanted to share what works so if anyone can highlight mistake, I can fix it or if they can fix it, they can take it up.
Seems like a good merge. (In reply to zalan from comment #3) > Seems like a good merge. oops wrong bugzilla. please ignore. (In reply to Ahmad Saleem from comment #2) > Created attachment 466314 [details] > GitHub Patch > > I manage to do merge and compile this but I think Line 930 is problematic > since it does not fix the failing test case, which I have attached here on > local build. > > Just wanted to share what works so if anyone can highlight mistake, I can > fix it or if they can fix it, they can take it up. WebKit has addRect() and not operator(). just replace it and it will start working. (In reply to zalan from comment #5) > (In reply to Ahmad Saleem from comment #2) > > Created attachment 466314 [details] > > GitHub Patch > > > > I manage to do merge and compile this but I think Line 930 is problematic > > since it does not fix the failing test case, which I have attached here on > > local build. > > > > Just wanted to share what works so if anyone can highlight mistake, I can > > fix it or if they can fix it, they can take it up. > WebKit has addRect() and not operator(). just replace it and it will start > working. Worked!!! (Test case also fixed - test in Minibrowser). Going to draft PR first and once I will fix all bugs, I will do ask for review. :-) (In Draft) PR - https://github.com/WebKit/WebKit/pull/13853 Committed 264058@main (9db465cd1226): <https://commits.webkit.org/264058@main> Reviewed commits have been landed. Closing PR #13853 and removing active labels. |