Bug 24993

Summary: Standalone media should use a smaller intrinsic height
Product: WebKit Reporter: Dean Jackson <dino>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, eric.carlson, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch for standalone audio fix simon.fraser: review+

Dean Jackson
Reported 2009-04-01 14:33:53 PDT
Standalone media documents use a <video> element to play all media. In the case of audio, this should not use the default intrinsic height of 150. This came up as a bug report from someone who was opening audio files in popup windows that were 100px high, and thus the controls were not visible. By setting the intrinsic height for all media on standalone documents to 0 (actually 1, see patch comments) everything works ok. Video gets resized to its native dimensions when the video loads. <rdar://problem/6458142> REGRESSION: Audio files have misplaced control bars (20687)
Attachments
patch for standalone audio fix (1.70 KB, patch)
2009-04-01 14:37 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2009-04-01 14:37:35 PDT
Created attachment 29179 [details] patch for standalone audio fix
Dean Jackson
Comment 2 2009-04-01 17:58:37 PDT
Committed r42159 M WebCore/ChangeLog M WebCore/rendering/RenderVideo.cpp
Note You need to log in before you can comment on or make changes to this bug.