Bug 249919 – [contain-intrinsic-size] auto-009.html is failing

• Component: CSS
• Status: RESOLVED FIXED

[cathiechen]

To fix auto-009.html, looks like we need to store last remembered width and height instead of size.

[cathiechen]

Created attachment 464232 [details]
WIP-patch

[Radar WebKit Bug Importer]

<rdar://problem/103860290>

[Oriol Brufau]

Comment on attachment 464232 [details]
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464232&action=review

> Source/WebCore/dom/ElementRareData.cpp:44
> +    LayoutUnit lastRemembedHeight;

These should be logical (since ResizeObserver tracks changes to the logical sizes).

[cathiechen]

Created attachment 464921 [details]
WIP-patch

[cathiechen]

(In reply to Oriol Brufau from comment #3)
> Comment on attachment 464232 [details]
> WIP-patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=464232&action=review
> 
> > Source/WebCore/dom/ElementRareData.cpp:44
> > +    LayoutUnit lastRemembedHeight;
> 
> These should be logical (since ResizeObserver tracks changes to the logical
> sizes).

Done, thanks:)

[Oriol Brufau]

Comment on attachment 464921 [details]
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464921&action=review

> Source/WebCore/dom/Element.cpp:4484
> +void Element::clearLastRememberedLogicalSize()

Maybe clearLastRememberedSizes? No need to consider it logical since it's clearing both.

> Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:351
> +            element.setLastRememberedLogicalWidth(LayoutUnit(-1));

You are checking the physical containIntrinsicWidthType but clearing the logical setLastRememberedLogicalWidth.
I don't think this will work in a vertical writing mode.

[cathiechen]

Comment on attachment 464921 [details]
WIP-patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464921&action=review

>> Source/WebCore/rendering/updating/RenderTreeUpdater.cpp:351
>> +            element.setLastRememberedLogicalWidth(LayoutUnit(-1));
> 
> You are checking the physical containIntrinsicWidthType but clearing the logical setLastRememberedLogicalWidth.
> I don't think this will work in a vertical writing mode.

Ah, yes, should check writing mode here! Will do, thanks!

[cathiechen]

Created attachment 464940 [details]
WIP-patch

[cathiechen]

Created attachment 464941 [details]
WIP-patch

[cathiechen]

Created attachment 464942 [details]
WIP-patch

[cathiechen]

Pull request: https://github.com/WebKit/WebKit/pull/10359

[EWS]

Committed 260939@main (d8e31024efa9): <https://commits.webkit.org/260939@main>

Reviewed commits have been landed. Closing PR #10359 and removing active labels.