Summary: | Add V8 custom bindings for Node insert/remove methods | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mike Belshe <mbelshe> | ||||||
Component: | WebCore JavaScript | Assignee: | Mike Belshe <mbelshe> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mike Belshe
2009-03-31 19:42:55 PDT
Created attachment 29154 [details]
patch
Comment on attachment 29154 [details]
patch
Looks good -- one question? For DOM exception handling, can we use the throwError(ExceptionCode) helper from V8Proxy.h? It returns v8::Undefined(), but that should still work. Right?
Comment on attachment 29154 [details]
patch
Doh! I think Node.idl change is missing from the patch.
Created attachment 29267 [details]
updated patch to address comments.
Sorry for the clerical error; Node.idl changes attached.
Landed as http://trac.webkit.org/changeset/42248. |