|Summary:||Add V8 custom bindings for Node insert/remove methods|
|Product:||WebKit||Reporter:||Mike Belshe <mbelshe>|
|Version:||528+ (Nightly build)|
Description Mike Belshe 2009-03-31 19:42:55 PDT
This change allows us to take advantage of WebKit's lazyattach, which provides a significant performance win on dom manipulations.
Comment 2 Dimitri Glazkov (Google) 2009-04-01 09:16:07 PDT
Comment on attachment 29154 [details] patch Looks good -- one question? For DOM exception handling, can we use the throwError(ExceptionCode) helper from V8Proxy.h? It returns v8::Undefined(), but that should still work. Right?
Comment 3 Dimitri Glazkov (Google) 2009-04-01 09:17:25 PDT
Comment on attachment 29154 [details] patch Doh! I think Node.idl change is missing from the patch.
Comment 4 Mike Belshe 2009-04-05 14:17:09 PDT
Created attachment 29267 [details] updated patch to address comments. Sorry for the clerical error; Node.idl changes attached.