Bug 249760
| Summary: | Match epsilon value to output digits in TextStream.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
I noticed that Blink team added this commit to reduce flakiness in the test cases (especially SVG), I just wanted to get opinion whether it is something worth adding or changing in WebKit:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=186819
Webkit GitHub Source - https://src.chromium.org/viewvc/blink?view=revision&revision=186819
Commit message crux:
"This patch brings epsilon to 0.01 so we shouldn't change whether or not we display a fraction
without a numerical difference in our output."
Just wanted to get opinion.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Looks like we have this code in Source/WTF/wtf/text/TextStream.cpp, but I don't really know what it's meant to do.
I don't think that we have any flakiness in render tree dumps, although we do have platform specific results that differ only a little.
alan
I am not aware of any flakiness either.
Radar WebKit Bug Importer
<rdar://problem/103750146>
Ahmad Saleem
Nothing much to do here.