Bug 24971

Summary:

Setting style.height = value in javascript doesn't work in tablerows(<tr>)

Product:

WebKit

Reporter:

jasneet <jasneet>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, dbates, developer, eric, gyll, hyatt, jasneet, karinag, mike.aizatsky, mitz

Priority:

Keywords:

HasReduction, InRadar

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
testcase	none
Patch with test case	none
Patch with test case	none
Patch with test case	hyatt: review+

Description jasneet 2009-03-31 17:20:11 PDT

I Steps:
Go to attached testcase

II Issue: 
When setting the second row to 200px by javascript:

In IE/Firefox, the second row is just set to 200px, other rows with their height unchanged.
In Chrome/Safari, all rows are reset to default minimum height, regardless the specified height in other rows.

III Other Browsers:
FF3: OK
IE7: OK 

IV Nightly tested: 42138

Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=8355

Comment 1 jasneet 2009-03-31 17:20:30 PDT

Created attachment 29144 [details]
testcase

Comment 2 mitz 2009-08-12 15:20:41 PDT

<rdar://problem/7138265>

Comment 3 mitz 2009-10-25 23:43:37 PDT

*** Bug 30756 has been marked as a duplicate of this bug. ***

Comment 4 Daniel Bates 2009-11-15 22:38:10 PST

Created attachment 43267 [details]
Patch with test case

I have only tested this patch under the Mac build, hopefully their won't be platform pixel differences that require the layout test to be rebased per platform (but I'll check tomorrow).

Also, want to consult some people on this patch.

I am open to suggestions.

Comment 5 Daniel Bates 2009-11-15 22:43:43 PST

CC'ing David Hyatt, Beth Dakin, and Eric Seidel on this issue, since they may have some insight on this patch and on rendering, tables, and CSS in general.

Comment 6 Daniel Bates 2009-11-16 17:30:44 PST

Created attachment 43334 [details]
Patch with test case

Updated the included test case based on file LayoutTests/fast/table/row-height-recalc.html

Generated pixel-test and render-tree results for both the Mac and Windows builds.

Comment 7 Daniel Bates 2009-11-16 17:33:23 PST

For your reference, while writing this patch, I consulted section 17.5.3 of the W3C CSS 2.1 spec. <http://www.w3.org/TR/CSS2/tables.html#height-layout>.

Comment 8 Daniel Bates 2009-11-16 17:35:06 PST

This bug also affects the Mac build.

Comment 9 Daniel Bates 2009-11-18 15:14:41 PST

Created attachment 43466 [details]
Patch with test case

Added pixel test/render-tree results for Qt build.

Comment 10 Dave Hyatt 2009-11-18 15:23:22 PST

Comment on attachment 43466 [details]
Patch with test case

r=me

Comment 11 Daniel Bates 2009-11-18 15:25:09 PST

Just noticed that I forgot to update the LayoutTest/ChangeLog to reflect the pixel-text/render-tree results for QT. Will update this before I land.

Comment 12 Daniel Bates 2009-11-18 16:06:20 PST

Committed r51151: <http://trac.webkit.org/changeset/51151>

Comment 13 Daniel Bates 2010-01-24 15:16:48 PST

*** Bug 15151 has been marked as a duplicate of this bug. ***

Comment 14 Daniel Bates 2010-10-10 11:08:55 PDT

*** Bug 19883 has been marked as a duplicate of this bug. ***