Bug 249607
| Summary: | Div having contentEditable and display:grid cannot be edited if it is empty | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | karlcow, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another failing test case:
Test Case - https://jsfiddle.net/0apf247s/
^Fail in Safari 16.2 & STP160, it only passes in Chrome Canary 111 while Firefox Nightly 110 also fail two sub-tests.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/514f6e13a5a64aa675d3dc42a2707161d71737c2
I haven't looked into whether it can be merged 1-1 but I just wanted to raise this so we can track this bug.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/103713842>
Ahmad Saleem
Don't need to this change: https://searchfox.org/wubkat/source/Source/WebCore/dom/Position.cpp#1006
Already have:
>> is<RenderBlockFlow>(*renderer) || is<RenderGrid>(*renderer) || is<RenderFlexibleBox>(*renderer)
and this needs to be updated:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderFlexibleBox.cpp#1366
Still looking for other bits in RenderGrid.cpp.
Ahmad Saleem
I think 'RenderGrid' related changes would be here:
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderGrid.cpp#363
Ahmad Saleem
This is already done - https://commits.webkit.org/159585@main
We might be failing subtest due to innerText difference. Closing this.