Bug 24922

Summary:

change WorkQueue-based navigation tests to not depend on synchronous form submission

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Tools / Tests

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

zwarich

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

22378

Attachments:

Description	Flags
patch	zwarich: review+

Description Darin Adler 2009-03-29 08:52:34 PDT

Some of the regression tests depend on our current synchronous form submission, which is not the same as other browsers.

Comment 1 Darin Adler 2009-03-29 09:38:51 PDT

Created attachment 29046 [details]
patch

Comment 2 Cameron Zwarich (cpst) 2009-03-29 10:04:04 PDT

Comment on attachment 29046 [details]
patch

> // Not dumping as text since the DumpRenderTree does not dump the text conetnt of child frames.

There is a typo here: "conetnt" should be "content". After runTest() there should probably be a blank line before subframeLoaded(), but I am not sure how strict we are on style in test files.

Other than that, r=me.

Comment 3 Darin Adler 2009-03-29 12:27:41 PDT

http://trac.webkit.org/changeset/42082