Bug 249149
| Summary: | [Wasm-GC] Adjust struct.new opcode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Asumu Takikawa <asumu> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247394 | ||
Asumu Takikawa
The current implementation for Wasm GC struct operations is using an opcode for `struct.new` that is compatible with current V8 and Firefox (https://docs.google.com/document/d/14xWenN0lUoHa9TiDJd8yYR8ZKjgOhgO7iEmfrAuA1_M/edit#heading=h.9dwoku9340md), but not with the actual spec https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md.
The difference is using 0xfb01 or 0xfb07. The opcode numbers are likely to get renumbered eventually as part of a "cleanup" phase of the proposal.
I think we should potentially just support both opcode variations in the parser for now, which will allow us to run wasm programs produced with V8 in mind while also passing tests originating from the spec.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Asumu Takikawa
Pull request: https://github.com/WebKit/WebKit/pull/7532
EWS
Committed 257821@main (67cbb39ef6cc): <https://commits.webkit.org/257821@main>
Reviewed commits have been landed. Closing PR #7532 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103330695>