Bug 248879
| Summary: | Properly resolve fullscreen API promises | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | DOM | Assignee: | Tim Nguyen (:ntim) <ntim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andrewhodel, ddkilzer, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=248900 https://bugs.webkit.org/show_bug.cgi?id=282998 |
||
Tim Nguyen (:ntim)
exitFullscreen() promises should resolve in FullscreenManager::finishExitFullscreen().
requestFullscreen() promises should resolve in FullscreenManager::willEnterFullscreen().
These methods FullscreenManager are called asynchronously, so it might be tricky however.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tim Nguyen (:ntim)
rdar://103074395
Tim Nguyen (:ntim)
Pull request: https://github.com/WebKit/WebKit/pull/7415
EWS
Committed 257668@main (9696329f7af6): <https://commits.webkit.org/257668@main>
Reviewed commits have been landed. Closing PR #7415 and removing active labels.
David Kilzer (:ddkilzer)
I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now.
David Kilzer (:ddkilzer)
(In reply to David Kilzer (:ddkilzer) from comment #4)
> I'm pretty sure this is causing 4-5 layout test crashes on EWS runs now.
Specific examples:
PR: <https://github.com/WebKit/WebKit/pull/7430>
Run: <https://ews-build.webkit.org/#/builders/73/builds/21968>
Results: <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/c887a3c0-21968/results.html>
Crashing tests:
fullscreen/full-screen-request-removed.html
media/modern-media-controls/layout-node/addChild.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
media/modern-media-controls/seek-forward-support/seek-forward-support.html
PR: <https://github.com/WebKit/WebKit/pull/7428>
Run: <https://ews-build.webkit.org/#/builders/73/builds/21964>
Results: <https://ews-build.s3-us-west-2.amazonaws.com/macOS-BigSur-Release-WK1-Tests-EWS/37345d6b-21964/results.html>
Crashing tests:
fullscreen/full-screen-request-removed.html crash log sample history
media/modern-media-controls/media-controls/media-controls-display-above-captions.html
media/modern-media-controls/mute-button/mute-button.html
media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html
media/modern-media-controls/start-support/start-support-audio.html
pageoverlay/overlay-large-document-scrolled.html
These seem to be fixed as of Monday morning, though.
Tim Nguyen (:ntim)
Crashes were fixed by https://github.com/WebKit/WebKit/pull/7443
Karl Dubost
*** Bug 282998 has been marked as a duplicate of this bug. ***