Bug 24881

Summary: Fix WebInspector's ElementsTreeOutline to make valid editingCancelled call.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: WebCore Misc.Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch with the fix timothy: review+

Description Pavel Feldman 2009-03-27 06:32:08 PDT
Fix WebInspector's ElementsTreeOutline to make valid editingCancelled call.
Comment 1 Pavel Feldman 2009-03-27 06:33:09 PDT
Created attachment 29008 [details]
Patch with the fix
Comment 2 Maciej Stachowiak 2009-05-22 02:22:29 PDT
I don't understand this change. Why is the new way right? Maybe Tim Hatcher should look at this.
Comment 3 Pavel Feldman 2009-05-22 02:44:28 PDT
I think this has been landed / patched long ago.
Comment 4 David Kilzer (:ddkilzer) 2009-05-22 06:25:44 PDT
(In reply to comment #3)
> I think this has been landed / patched long ago.

Looking at r43858, it has not been landed.  Reopening.

http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOutline.js#L573
Comment 5 Pavel Feldman 2009-05-22 06:40:23 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > I think this has been landed / patched long ago.
> 
> Looking at r43858, it has not been landed.  Reopening.
> 
> http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOutline.js#L573
> 

Sorry, my bad. Timothy, could you take a quick look at this?
Comment 6 Timothy Hatcher 2009-05-22 08:49:39 PDT
This didn't land yet. Landing now.
Comment 7 Timothy Hatcher 2009-05-22 09:11:47 PDT
http://trac.webkit.org/changeset/44046