Bug 24878

Summary:

[GTK] Use GtkBinding system to handle key events in WebView

Product:

WebKit

Reporter:

Xan Lopez <xan.lopez>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
webviewbindings.patch	zecke: review+

Description Xan Lopez 2009-03-27 01:43:21 PDT

Patch coming.

Comment 1 Xan Lopez 2009-03-27 01:47:15 PDT

Created attachment 29005 [details]
webviewbindings.patch

Comment 2 Holger Freyther 2009-03-30 06:04:45 PDT

Comment on attachment 29005 [details]
webviewbindings.patch


> +    case GTK_MOVEMENT_VISUAL_POSITIONS:
> +        if (count == 1)
> +            view->scrollBy(IntSize(cScrollbarPixelsPerLineStep, 0));
> +        else if (count == -1)
> +            view->scrollBy(IntSize(-cScrollbarPixelsPerLineStep, 0));
> +      break;

wrongly placed.



yeah!!!

Comment 3 Xan Lopez 2009-03-30 08:49:00 PDT

Thanks, committed as r42102.