Bug 24878

Summary: [GTK] Use GtkBinding system to handle key events in WebView
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
webviewbindings.patch zecke: review+

Xan Lopez
Reported 2009-03-27 01:43:21 PDT
Patch coming.
Attachments
webviewbindings.patch (13.06 KB, patch)
2009-03-27 01:47 PDT, Xan Lopez 		zecke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2009-03-27 01:47:15 PDT
Created attachment 29005 [details] webviewbindings.patch
Holger Freyther
Comment 2 2009-03-30 06:04:45 PDT
Comment on attachment 29005 [details] webviewbindings.patch > + case GTK_MOVEMENT_VISUAL_POSITIONS: > + if (count == 1) > + view->scrollBy(IntSize(cScrollbarPixelsPerLineStep, 0)); > + else if (count == -1) > + view->scrollBy(IntSize(-cScrollbarPixelsPerLineStep, 0)); > + break; wrongly placed. yeah!!!
Xan Lopez
Comment 3 2009-03-30 08:49:00 PDT
Thanks, committed as r42102.
Note You need to log in before you can comment on or make changes to this bug.