Bug 24876
| Summary: | fast/forms/select-max-length.html times out in debug builds due to HTMLSelectElement::setLength being O(N^2) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> |
| Component: | Forms | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andersca, ap, aroben, mrowe, pkasting, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Mark Rowe (bdash)
After <http://trac.webkit.org/changeset/42012>, fast/forms/select-max-length.html is frequently timing out on my MacBook Pro in a debug build. Running the test manually shows it takes around 17 seconds to complete, which is above the new 15s threshold.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
It looks like HTMLSelectElement::setLength() is O(N^2)
Adam Roben (:aroben)
Maybe we should back out r42012
Adam Roben (:aroben)
(Obviously it would be good to improve the test's performance, too!)
Mark Rowe (bdash)
*** Bug 24889 has been marked as a duplicate of this bug. ***
Mark Rowe (bdash)
Fixing HTMLSelectElement::setLength would be a better idea, unless there are other tests also timing out.
Mark Rowe (bdash)
I have a patch that drops the time of this test from 17 seconds down to around 4.5 seconds by improving HTMLSelectElement::setLength. I need to verify that the change is safe in the face of fun things like mutation events, and then will put a patch up for review.
Mark Rowe (bdash)
Fixed in r42050.