Bug 24861

Summary:

Chromium port does not render decorations for <input type="search">

Product:

WebKit

Reporter:

Peter Kasting <pkasting>

Component:

Forms

Assignee:

Peter Kasting <pkasting>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ojan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
patch v1	none
patch v2	eric: review+

Description Peter Kasting 2009-03-26 16:36:15 PDT

Patch coming shortly

Comment 1 Peter Kasting 2009-03-26 16:37:14 PDT

Created attachment 28993 [details]
patch v1

Comment 2 Peter Kasting 2009-03-26 16:55:06 PDT

Created attachment 28994 [details]
patch v2

Now compiles on Linux, hopefully

Comment 3 Eric Seidel (no email) 2009-03-26 17:23:47 PDT

Comment on attachment 28994 [details]
patch v2

Peter informs me this is just copy/paste code.  That seems like a really bad idea.  Especially for this volume of code.  Can't we use a RenderThemeChromium superclass here?

Comment 4 Eric Seidel (no email) 2009-03-26 17:53:27 PDT

Comment on attachment 28994 [details]
patch v2

Peter says he's about to refactor this as his next patch.  So this is a fine intermediate step.

Comment 5 Peter Kasting 2009-03-27 11:08:04 PDT

Fixed in r42044.